Repository navigation
Support assignment expressions, yield from and starred targets - #80
Merged
Merged
Conversation
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First item of #71: the three syntax forms that rejected whole files on the large projects measured in #69.
test: define assignment expressions, yield from and starred targets), implementation follows.NamedExpr; the scope analysis binds the target in the enclosing function, also from inside a comprehension as PEP 572 specifies; the CFG builder lays the walrus out as an assignment before the statement that reads it, and awhile (line := f()):condition is recomputed every iteration like the other control-flow conditions.yield from.Yieldgains adelegateflag; the adapter builds it instead of failing; lowering is unchanged.Starred; lowering gives the starred target the slice the others leave and indexes the targets after it from the end; scopes, the CFG builder and the reassigned-parameter scan follow the starred value.syntax-errornotes are replaced by the findings of those files.Part of #71.