Repository navigation
Collect a module's functions once and stop walking it per function - #79
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #69: measurements on large projects and the hot spot they revealed.
--cachebrings healthchecks to 1.1 s;--jobs 4to 8 s.Noneboth for "top-level" and "not found", so every named function fell through to the lambda fallback, and the collection itself was never memoised. About a quarter of the cold time.test: define the module function collection as computed once), then the fix:analyzable_functionsis memoised per module (identity-keyed, bounded), and_enclosingdistinguishes a top-level definition from an absent one. healthchecks drops from 9.5 s to 7 s, rich from 7.2 s to 5.8 s, wagtail from 123 s to 85 s, same findings.yield fromand starred targets rejecting whole files; hex digests floodinghigh-entropy-string; credentials in test fixtures; Djangoredirect("name", arg)); they are recorded as tasks on Precision: nonlocal write-back and a broader regression corpus #71.Part of #69.