Repository navigation
Bundle the plugins in the package and add the publication workflow - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First deliverable of the product track: the analyzer installs as a self-contained package and can be published.
test: define packaging and bundled plugin behavior), implementation follows.plugins/into the package, undercoretrace_python/bundled/. They are part of the wheel (manifests, models and detectors included; tests and test repositories excluded), andengine.BUNDLED_PLUGINSpoints at them.--checkloads the bundled plugins by default;--plugins DIRadds directories on top,--no-bundled-pluginsruns without them. A manifest found under several roots is loaded once.pyproject.toml: classifiers, project URLs,buildandtwinein the dev extras, bundled plugins excluded from mypy (they are loaded by path, not imported). The installed distribution version matchescoretrace_python.__version__.packagejob: build the sdist and wheel,twine check, install the wheel in a clean virtual environment and run a--checkon a sample; the archives are uploaded as an artifact.release.yml: on av*tag, verify that the tag matches the version inpyproject.toml, build, check and publish to PyPI through trusted publishing (environmentpypi, no stored token).--plugins plugins/;docs/architecture.md§25 points at the bundled directory.To publish a release
One-time setup on pypi.org: add a trusted publisher for
CoreTrace/coretrace-python-analyzer, workflowrelease.yml, environmentpypi, and create thepypienvironment in the repository settings. Thengit tag v0.1.0 && git push origin v0.1.0.