Repository navigation
feat: remaining documented limits - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The four documented limits, closed at Hugo's request.
test: define positional patterns, nonlocal, local classes and while conditions), implementation follows.case Point(0, y)uses the class's__match_args__when the class is defined in the module, explicitly or as the field order of a@dataclass, which needed the HIR to keep bare annotated declarations (Declaration) instead of dropping them; for an unknown class each position becomes a conservative attribute of the subject, so the match lowers and taint still flows through the captures.nonlocal: the declared name becomes a local of the nested function initialised from the captured value, so the body is analysed and a sink inside it sees the write. The write does not flow back to the enclosing function yet; the test pins that down as the remaining approximation.MakeClassvalue bound to the name, bases and decorators evaluated, and the methods analysed as nested functions (outer.Inner.run), captured variables included.whilecondition: the loop becomeswhile Truewith the condition laid out at the top of the body and abreak, theelseclause running before it, so the condition is recomputed every iteration.breakoutside a loop, which the parser accepts and the CFG rejects.On the sixteen repositories nothing changes.