Repository navigation
feat: self state across methods - #62
Merged
Merged
Conversation
…and seed framework-called methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second point of the consolidation: attribute state on
selfacross methods.self.cmd = argvin__init__thenos.system(self.cmd)inrun()was invisible, each method seeing its ownself.test: define self state across methods), implementation follows.App(x)is a call toApp.__init__whose receiver is the new object,app.run()on an instance,self.run()inside a method anda.run()on a parameter annotated with the class are calls to the class's methods. Unknown classes stay unknown.selfas a dependency on its first parameter, and callers now map that parameter onto the receiver, contents included, so a value stored by__init__or a setter method and read by another flows through the object, reported at the call site withthrough. It works across files through the project index, whereApp(x)looks upApp.__init__.selffrom their own inputs and sources:self.cmd = request.POST[...]in a Django view'spostreachesos.systemin itsget. Methods the project calls get theirselffrom the caller instead, so nothing is invented for a class nobody drives.On the sixteen repositories nothing changes: their classes hold no attacker-controlled state between methods.