Repository navigation
feat: expression syntax pass - #52
Merged
Merged
Conversation
…om and tuple loop targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First syntax pass after the roadmap, driven by the repositories under
tests-project/: most of their files were rejected by the frontend for everyday constructs. This pass covers the ones that add no control flow; conditional expressions, lambdas, comprehensions, nested function definitions andglobalassignments are the next pass.test: define f-strings, slices, unpacking, raise from and tuple loop targets), implementation follows.FormattedString(constant and formatted parts, conversions and format specs dropped, nested spec expressions kept as parts),Slice,Starred,Dictitems with aNonekey for**mapping,Raise.cause. Afor k, v in itemsloop binds a hidden local and destructures it with a tuple assignment at the top of its body, so scopes, CFG, lowering and SSA are unchanged.BuildString,BuildSlice,Call.starred,unpackedonBuildList,BuildTupleandBuildDict,Raise.cause; printed asbuild_string,build_slice,*%n,**%nandraise %e from %c.run(*args)still reports; unpacked collections carry the contents of what they unpack in taint, dependence and the heap; everything else flows through the generic operand rules, so refutation through an f-string works unchanged..pyfile that cannot be decoded becomes asyntax-errornote instead of aborting the whole run, and dependency files honour their byte order mark, sincepip freezeon Windows writes UTF-16requirements.txtfiles; two repositories had them and crashed the run.Measured on the twelve repositories under
tests-project/: f-strings, slices,raise from, tuple loop targets and starred arguments no longer block any file; the remaining notes are conditional expressions, lambdas, comprehensions, nested functions andglobalassignments.