Repository navigation
fix: project discovery robustness - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Robustness fixes found by running the analyzer on real repositories.
test: define discovery of virtual environments and non-identifier module names), fixes follow.discover_sourcesskips any virtual environment, recognised by thepyvenv.cfgthevenvmodule writes at its root, whatever the directory is called (env/,tools/), on top of the fixed list of tooling directories. A Windows venv namedenv/with 2,570 files was being analysed.project_symboltolerates module and package names that are not Python identifiers (network-topologer,docutils-script.py): invalid characters become underscores and a leading digit gets a prefix, so the project index stays valid instead of the engine raisingValueErrorand aborting the whole run. Such modules cannot be imported by that name anyway, so nothing else resolves to them.Found on the
Pylinkitandnetwork-topologerrepositories; both now analyse to completion.