Repository navigation
feat(findings): mark findings in vendored code with their context - #252
Closed
SizzleUnrlsd wants to merge 1 commit into
Closed
SizzleUnrlsd wants to merge 1 commit into
SizzleUnrlsd wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by the PR from feat/vendored-origin: the review asked to keep the vendored origin apart from the test context, which reworks this branch beyond a follow-up commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the test-context PR (#244). Merge after it.
Summary
third_party,third-party,vendororvendoreddirectory carrycontext: vendored, through the classification of findings: test code is recognised only by hardcoded-credential #244.vendoredcomes first: the test code of a vendored project is vendored, and the context replaces the one a rule gave, without changing its confidence.externalis left out on purpose: projects often name their own code that way.Verification
tests/test_vendored_context.py, new: 11 tests, covering:No existing test changed.
Full suite green, apart from the local
test_packagingmetadata issue.ruff checkandmypyclean.On a C++ project vendoring GoogleTest, the 7 findings are still reported, all with
context: vendored.Closes #243