Repository navigation
feat(findings): show the context of test code on every finding - #251
Merged
Merged
Conversation
The context is judged on the path from the root of the report: for a file checked alone, its own directory, as the command line reports it. analyze_file takes that root explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the dynamic-import PR, which only shares an adjacent line of
docs/usage.md. Merge after it.Summary
findings/context.py:is_test_code: whether a path is test code;code_context: the context a finding carries.hardcoded-credentialusesis_test_code, so its behaviour is unchanged.context: testto every finding in test code, judged on its path relative to the project root, before refiner plugins run, so that they can read it. A context a rule gives (example) stays.injection.Verification
tests/test_code_context.py, new: 16 tests, covering:tests;No existing test changed.
Full suite green, apart from the local
test_packagingmetadata issue.ruff checkandmypyclean. Regression snapshots unchanged.Known, not changed here:
hardcoded-credentialclassifies the absolute path, so a project located under a directory namedtestsgets all its credentials at low confidence. Fixing that needs the project root in the plugin API and changes verdicts; it belongs to its own issue.Closes #244