build(www): deploy the hosted editor from this repo on Vercel - #42
Open
DavidBabinec wants to merge 1 commit into
Open
DavidBabinec wants to merge 1 commit into
DavidBabinec wants to merge 1 commit into
Conversation
coreframework.com/app embeds the editor from alpha.coreframework.com, whose Vercel project was still connected to the old private repo and served 1.10.4. This adds the build settings Vercel needs to build www from packages/www in this monorepo, pinned to the repo's Bun 1.3.11, and documents that a merge to main is the web app's release. No SPA rewrite: the editor has no client-side routes, and a catch-all would answer a missing asset with index.html instead of a 404.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coreframework.com/app is stuck on 1.10.4. It embeds the editor from alpha.coreframework.com, which is the Vercel project
core-bunch/core-framework. That project is still connected to the old private repo (its last production deploy is80abe2ce, "Release: 1.10.4"). This addspackages/www/vercel.jsonso the project can build www from this repo with Root Directorypackages/www, using Bun 1.3.11 viabunxas Vercel's docs recommend for pinning. It also documents the web app's release path inRELEASING.md, the README and thereleaseskill: repo, branch, project, and that a merge tomaindeploys.No SPA rewrite: the editor has no client-side routes, and a catch-all would serve
index.htmlfor a missing chunk instead of a 404. The Vercel dashboard switch is still a manual step, done separately.Verification
Served that
distinside an iframe host mirroring the website: it loaded a project saved by live 1.10.4 and completed a save round-trip.