Repoint weekly search-query report to the Gap Reports Notion page#143
Merged
Conversation
Consolidate the weekly and monthly reports onto the single Gap Reports page (3793aa38) instead of the old Analytics/pathfinder page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates the weekly and monthly reports onto a single Notion destination — the Gap Reports page (
3793aa38-1852-80a5-89d3-c3d37147aa22). The weekly search-query report previously published to the old Analytics/pathfinder page (3373aa38-1852-8152-a10b-e4aa1b8a667e); it now lands on the same Gap Reports page the monthly gap-analysis already uses.The monthly gap-analysis workflow is untouched (it already pointed at Gap Reports).
Changed locations
.github/workflows/weekly-search-report.yml(line 80) —NOTION_PARENT_PAGE_IDenv → Gap Reports id (adjacent comment updated to match).scripts/weekly-search-report/weekly-search-report.ts(line 938) —DEFAULT_PARENT_PAGE_IDfallback → Gap Reports id.Verification
Old id — zero hits across the whole repo:
New id — both weekly locations now present alongside the pre-existing monthly ones:
The weekly script has no
--dry-runmode, so no live run was performed (that would post to Slack #engr and publish a real Notion page). Verification is grep/inspection-based.Quality gate: prettier clean on the edited TS file,
tsc --noEmitclean, full test suite green (3554 passed / 1 skipped).