Fix fresh desktop setup and Mac sign-in - #591
Merged
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 17, 2026 01:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh desktop setup could fail during sign-in because it also installed local dependencies. Mac 0.0.12 additionally lacked automatic Bun installation and could fail OpenAI sign-in with
rootlessport conflict with ID 1under Podman.Validated visually in the packaged Mac app: installation completed before sign-in; real OpenAI subscription sign-in; actual Hacker News browsing and a rendered chart matching the browser screenshot; narrow/wide details and draft preservation; a typed CEL rule and successful dry run; Cmd+Q, reopening, and explicit Stop. The exact Podman error was reproduced, then the corrected mapping passed both an HTTP callback check and a real Google-to-OpenAI browser authorization using the published auth image, without an API key.
The official Bun binary and all 2,388 deployment dependencies installed successfully with an empty PATH. This checks independence from developer tools on the test host; it does not claim a separate Mac without those tools was used. App testing used the PR frontend/native code with released v0.0.12 backend images. The final native package was rebuilt and reopened at 4820f9e. Windows was not manually retested for this PR.
Checks passed: 835 app tests, 107 desktop UI tests, 462 native library tests (3 existing live-service tests ignored), 135 native binary tests, and subsequent targeted installer/auth regressions. TypeScript, formatting, lint, Clippy across all targets, app production build, and the final packaged Mac build passed.
Validation screenshots and tracking: FOR-311.
Fixes FOR-311