fix(desktop): unblock Windows plan sign-in and space provider buttons - #582
Merged
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 16, 2026 14:24
Answer ConPTY's initial cursor query and retain its master through the sign-in exchange. Cover startup, child lifetime, and cleanup with a bounded native Windows regression. Fixes FOR-308
Modern ClosePseudoConsole returns asynchronously. Keep the native fixture deadline around its output reader reaching EOF before removing the test executable. Refs FOR-308
Recognize the plan prefix after label punctuation even when terminal cursor controls provide visual spacing. Extend the native Windows fixture through 92-character code submission and complete token receipt. Fixes FOR-308
guidovizoso
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fix Windows subscription sign-in and provider-button spacing:
%ProgramFiles%\Podman. Install Podman when Docker's CLI exists but its engine is stopped; preserve responding Docker.Fixes FOR-308
Where it runs
Desktop engine setup, plan sign-in, and provider UI. The callback remains loopback-only. No new server state, listener, port, schedule, or replica behavior.
Boundary and audit
Existing gateway identity, authorization, audit, and provider token exchanges are unchanged. Temporary diagnostic instrumentation is not shipped.
Changelog
No server changelog entry: these changes repair local desktop setup, authentication transport, and layout.
Proof
Actual non-admin Windows app, both subscriptions, no model API keys:
showLineChartcall rendered Jan=120, Feb=180, Mar=240. Claude initially claimed the chart without calling the tool; one explicit follow-up produced the verified chart. That first reply was not counted as a pass.Regression checks: native Windows engine fixtures and callback/ConPTY/token regressions failed before their fixes and passed afterward. The full Windows code exchange passes all 20 focused plan tests. The final NSIS installer built successfully. Earlier affected-suite checks passed: 588 Rust tests, 96 desktop tests, formatting, Clippy, lint, typecheck, and frontend build. Provider layouts were visually checked at 900px and 375px.
Final-head CI:
bc07ae83— 18 passed, 3 skipped; Windows, macOS, and Linux checks green. Working tree and diff hygiene clean.