Shape human click, type and key payloads on POST /api/computers/:botId/human/:kind with 400 - #517
Merged
davidmckayv merged 4 commits intoSep 13, 2026
Conversation
…d/human/:kind with 400
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 13, 2026 05:16
davidmckayv
approved these changes
Sep 13, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Validated: per-gesture human-input validation is correct; rebased on current main (keeps #518), typecheck 0, human-input/computer-routes tests green (31), CI verify green on this sha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only scroll was checked on the takeover route. A click with {x:"ten"}, a type with {text:123} or a key with {} travelled to the computer untouched, surfacing as its 500 or a 200 no-op. The shapes are the ones the gateway HumanInput type already promises: click carries finite x/y viewport pixels, type carries string text, key carries a non-empty name. Scroll keeps its existing check.
Updates the old kind-override test to carry text so it still exercises the kind-wins guard under the new shape rule.
Tests: new server/tests/computer-human-input.test.ts (19 cases: happy paths, 7 malformed clicks, 4 types, 4 keys, scroll default) — 40 pass with routes + scroll-delta suites.