fix(cluster-templates): derive recipe base from slot-derived build VMID#10
Open
gabbelitoV2 wants to merge 1 commit into
Open
fix(cluster-templates): derive recipe base from slot-derived build VMID#10gabbelitoV2 wants to merge 1 commit into
gabbelitoV2 wants to merge 1 commit into
Conversation
cf now builds each VM under a slot-derived id (recipe base * 100 + slot index) so parallel builds don't collide. The post-processor passes that large id as CF_BUILT_VMID, but this script used it directly as the per-node template base and its `>= OFFSET` guard then aborted with exit 1 -- which, under `set -e` in vzdump-and-cleanup.sh, killed the post-processor before the sidecar was written, so the whole build was reported as "no artifacts created" despite a good .vma.zst. Recover the recipe base (RAW / 100 when >= OFFSET) before computing per-node VMIDs. A plain non-slot build still passes the base directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf now builds each VM under a slot-derived id (recipe base * 100 + slot index) so parallel builds don't collide. The post-processor passes that large id as CF_BUILT_VMID, but this script used it directly as the per-node template base and its
>= OFFSETguard then aborted with exit 1 -- which, underset -ein vzdump-and-cleanup.sh, killed the post-processor before the sidecar was written, so the whole build was reported as "no artifacts created" despite a good .vma.zst.Recover the recipe base (RAW / 100 when >= OFFSET) before computing per-node VMIDs. A plain non-slot build still passes the base directly.