Skip to content

Alarm tree filter - #4018

Draft
LordIdra wants to merge 23 commits into
ControlSystemStudio:masterfrom
LordIdra:alarm-tree-filter
Draft

LordIdra wants to merge 23 commits into
ControlSystemStudio:masterfrom
LordIdra:alarm-tree-filter

Conversation

@LordIdra

@LordIdra LordIdra commented Nov 12, 2026 •

Copy link
Copy Markdown

Part of #3995

Requires #3988

Changes

  • Adds an acknowledged field to SeverityLevel
  • Removes the 'expand to show active' and 'expand to show disabled' buttons and replace them with a single 'expand all button'
  • Added 4 filters (disabled, OK, active, and acknowledged) which filter the alarm tree to show only the corresponding alarms
    • Filters can be combined, to show e.g. active and acknowledged at the same time
    • I made my own icons for them but they're not the best
2026-11-12.09-55-07.mp4

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes: Manually tested
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@LordIdra LordIdra mentioned this pull request Nov 12, 2026
25 tasks
@sonarqubecloud

Copy link
Copy Markdown

@LordIdra

LordIdra commented Nov 17, 2026 •

Copy link
Copy Markdown
Author

Did some optimisation for filter/search but struggling to make any significant gains without bigger structural changes (like 1/3the time is now HashMap#get according to profiles). It's still reasonably fast though, about 0.5 seconds to refresh on 100,000 alarms on my machine. Have also updated expand/collapse buttons to only affect selected items to better work with large numbers of alarms.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant