Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul disable alarms dialog #4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Overhaul disable alarms dialog #4013
Changes from all commits
436310fb973cd4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 159 in app/alarm/model/src/main/java/org/phoebus/applications/alarm/AlarmSystem.java
Make member "disable_duration_presets" "protected".
Check warning on line 168 in app/alarm/model/src/main/java/org/phoebus/applications/alarm/AlarmSystem.java
Lambda should be used to defer string concatenation.
Check warning on line 25 in app/alarm/model/src/main/java/org/phoebus/applications/alarm/DisableDurationPreset.java
Remove this redundant constructor which is the same as a default one.
Check warning on line 37 in app/alarm/model/src/main/java/org/phoebus/applications/alarm/DisableDurationPreset.java
Remove this redundant constructor which is the same as a default one.
Check warning on line 124 in app/alarm/model/src/main/java/org/phoebus/applications/alarm/DisableDurationPreset.java
Explicitly specify the time zone by passing a ZoneId or a Clock to the .now() method.
Check warning on line 127 in app/alarm/model/src/main/java/org/phoebus/applications/alarm/DisableDurationPreset.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 3 in app/alarm/model/src/test/java/org/phoebus/applications/alarm/DisableDurationPresetTest.java
Remove this unused import 'org.hamcrest.Matchers'.
Check warning on line 17 in app/alarm/model/src/test/java/org/phoebus/applications/alarm/DisableDurationPresetTest.java
Remove redundant visibility modifiers from the methods of this test class.
Check failure on line 44 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/DateTimePicker.java
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.