Skip to content

🎨 Palette: [UX improvement] Accessible table-based form controls#520

Closed
seonghobae wants to merge 2 commits into
mainfrom
jules/palette-a11y-table-forms-3906382671852393558
Closed

🎨 Palette: [UX improvement] Accessible table-based form controls#520
seonghobae wants to merge 2 commits into
mainfrom
jules/palette-a11y-table-forms-3906382671852393558

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What

Added explicit aria-label attributes to the <select> element in GroupModal (used for assigning business groups to tables) and the <input> element in CardinalityModal (used for setting distinct counts for columns).

🎯 Why

In table-based layouts, form controls often lack explicit <label> elements wrapping them, relying instead on visual grid association (like a row header) which is not always reliably interpreted by screen readers. Providing a direct aria-label ensures that users relying on assistive technologies hear the full, unabbreviated context of the control they are focused on (e.g., instead of just hearing "Select", they hear "users 그룹 배정").

📸 Before/After

(Visuals remain unchanged as aria-label is visually hidden.)

♿ Accessibility

  • GroupModal: Screen readers now announce the table name when focusing the business group assignment select dropdown (e.g., "users 그룹 배정").
  • CardinalityModal: Screen readers now announce the column name when focusing the distinct count numeric input (e.g., "id distinct count").

PR created automatically by Jules for task 3906382671852393558 started by @seonghobae

Added explicit aria-label attributes to the <select> in GroupModal
and the <input> in CardinalityModal to ensure screen readers provide
full context for these table-based controls.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Superseded by #514 on current head.

Evidence checked in this loop:

Closing this duplicate to keep the queue on current-head checks and avoid re-running stale/superseded accessibility work.

@seonghobae seonghobae closed this Jul 11, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #514 on current head.

Evidence checked in this loop:

Closing this duplicate to keep the queue on current-head checks and avoid re-running stale/superseded accessibility work.

Understood. Acknowledging that this work is superseded and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant