Skip to content

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— 인라인 λ‘œλ”© ν…μŠ€νŠΈ ν”Όλ“œλ°± μΆ”κ°€#125

Open
seonghobae wants to merge 2 commits into
mainfrom
palette-async-button-loading-text-2587046488421731529
Open

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— 인라인 λ‘œλ”© ν…μŠ€νŠΈ ν”Όλ“œλ°± μΆ”κ°€#125
seonghobae wants to merge 2 commits into
mainfrom
palette-async-button-loading-text-2587046488421731529

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

λ¬Έμ„œ μ—…λ‘œλ“œ(submitDocument) 및 μž‘μ—… μž¬μ‹œλ„(retryActiveJob)와 같은 비동기 λ„€νŠΈμ›Œν¬ μž‘μ—…μ„ μˆ˜ν–‰ν•  λ•Œ λ²„νŠΌ ν…μŠ€νŠΈλ₯Ό λ‘œλ”© μƒνƒœλ‘œ λ³€κ²½ν•˜μ—¬ μ‚¬μš©μžμ—κ²Œ λͺ…ν™•ν•œ μ§„ν–‰ ν”Όλ“œλ°±μ„ μ œκ³΅ν•˜λŠ” UX κ°œμ„  μ‚¬ν•­μž…λ‹ˆλ‹€. μž‘μ—…μ΄ μ™„λ£Œλ˜κ±°λ‚˜ μ‹€νŒ¨ν•˜λ©΄ finally 블둝을 톡해 λ²„νŠΌμ˜ μ›λž˜ HTML이 μ•ˆμ „ν•˜κ²Œ λ³΅μ›λ©λ‹ˆλ‹€. ν”„λ‘ νŠΈμ—”λ“œ λ³€κ²½μœΌλ‘œ μΈν•œ ViewerUiControllerTest의 λ¬Έμžμ—΄ 검증 였λ₯˜λ₯Ό λ°©μ§€ν•˜κΈ° μœ„ν•΄ ν…ŒμŠ€νŠΈ μ–΄μ„€μ…˜μ„ μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 2587046488421731529 started by @seonghobae

- λ¬Έμ„œ μ—…λ‘œλ“œ 및 μž¬μ‹œλ„μ™€ 같은 비동기 μž‘μ—… 쀑 λ²„νŠΌμ˜ innerHTML을 μΌμ‹œμ μœΌλ‘œ 'Submitting...' 및 'Requesting retry...'둜 λ³€κ²½ν•˜μ—¬ μ§„ν–‰ μƒνƒœμ— λŒ€ν•œ 즉각적인 ν”Όλ“œλ°±μ„ μ œκ³΅ν•©λ‹ˆλ‹€.
- λ„€νŠΈμ›Œν¬ μš”μ²­μ΄ μ™„λ£Œλ˜λ©΄ finally λΈ”λ‘μ—μ„œ λ²„νŠΌμ˜ μ›λž˜ HTML ꡬ성을 μ•ˆμ „ν•˜κ²Œ λ³΅μ›ν•©λ‹ˆλ‹€.
- μ‚¬μš©μžμ˜ 쀑볡 클릭을 λ°©μ§€ν•˜κ³  μ‹œμŠ€ν…œμ˜ λ°˜μ‘μ„±μ„ λ†’μ—¬ UXλ₯Ό κ°œμ„ ν•©λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- λ¬Έμ„œ μ—…λ‘œλ“œ 및 μž¬μ‹œλ„μ™€ 같은 비동기 μž‘μ—… 쀑 λ²„νŠΌμ˜ innerHTML을 μΌμ‹œμ μœΌλ‘œ 'Submitting...' 및 'Requesting retry...'둜 λ³€κ²½ν•˜μ—¬ μ§„ν–‰ μƒνƒœμ— λŒ€ν•œ 즉각적인 ν”Όλ“œλ°±μ„ μ œκ³΅ν•©λ‹ˆλ‹€.
- λ„€νŠΈμ›Œν¬ μš”μ²­μ΄ μ™„λ£Œλ˜λ©΄ finally λΈ”λ‘μ—μ„œ λ²„νŠΌμ˜ μ›λž˜ HTML ꡬ성을 μ•ˆμ „ν•˜κ²Œ λ³΅μ›ν•©λ‹ˆλ‹€.
- μ‚¬μš©μžμ˜ 쀑볡 클릭을 λ°©μ§€ν•˜κ³  μ‹œμŠ€ν…œμ˜ λ°˜μ‘μ„±μ„ λ†’μ—¬ UXλ₯Ό κ°œμ„ ν•©λ‹ˆλ‹€.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant