๐จ Palette: Accessible Disabled State for Save Project Button#629
๐จ Palette: Accessible Disabled State for Save Project Button#629seonghobae wants to merge 2 commits into
Conversation
Replaces the invalid `span role="button"` wrapper around the disabled Save Project button in `App.tsx`. Uses `aria-disabled="true"` directly on the `<Button>` component and prevents click events manually. Adds `aria-disabled:` variants to the generic `Button` component in `components/ui/button.tsx` to handle identical styling to the native `disabled` attribute. Includes an interaction test to verify disabled click prevention.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaces the invalid `span role="button"` wrapper around the disabled Save Project button in `App.tsx`. Uses `aria-disabled="true"` directly on the `<Button>` component and prevents click events manually. Adds `aria-disabled:` variants to the generic `Button` component in `components/ui/button.tsx` to handle identical styling to the native `disabled` attribute. Includes an interaction test to verify disabled click prevention.
OpenCode Review Overview
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (4 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (4 files)"]
R1 --> V1["required checks"]
|
๐ก What
App.tsx์์ 'Save Project' ๋ฒํผ์ ๋นํ์ฑํ ์ํ๋ฅผ ์ฒ๋ฆฌํ๊ธฐ ์ํด ์ฌ์ฉํ๋spanํ๊ทธ ๋ํผ๋ฅผ ์ ๊ฑฐํ์ต๋๋ค.<Button>์ปดํฌ๋ํธ์ ์ง์ aria-disabled="true"๋ฅผ ์ ์ฉํ๊ณonClick={(e) => e.preventDefault()}๋ฅผ ์ฌ์ฉํ์ฌ ์ด๋ฒคํธ๋ฅผ ์ฐจ๋จํ์ต๋๋ค.components/ui/button.tsx์buttonVariants์aria-disabled:Tailwind variant๋ฅผ ์ถ๊ฐํ์ฌ ๋ค์ดํฐ๋ธdisabled์ ๋์ผํ ์๊ฐ์ ์คํ์ผ์ ๊ฐ๋๋ก ํ์ต๋๋ค.App.test.tsx์ ์ดaria-disabled๋ฒํผ์ด ํด๋ฆญ ์ด๋ฒคํธ๋ฅผ ์ ๋๋ก ๋ฐฉ์งํ๋์ง ํ์ธํ๋ ํ ์คํธ๋ฅผ ์ถ๊ฐํ์ต๋๋ค.๐ฏ Why
span๋ํผ)์ ์คํฌ๋ฆฐ ๋ฆฌ๋์ ํค๋ณด๋ ์ฌ์ฉ์์๊ฒ ์ ํจํ์ง ์์ ์ค์ฒฉ๋ ์ํธ ์์ฉ ์์๋ก ํผ๋์ ์ค ์ ์์ต๋๋ค.โฟ Accessibility
titleํดํ ํ์ ๊ธฐ๋ฅ์ ์ ์์ ์ผ๋ก ๋ณด์ฅํ๋ฉฐ DOM ๊ตฌ์กฐ๋ฅผ ์๋งจํฑํ๊ฒ ์ ์งํ์ต๋๋ค.PR created automatically by Jules for task 4421559010746020837 started by @seonghobae