refactor: 네이티브 버튼과 aria-disabled를 활용한 접근성 개선#620
Conversation
`span role="button"` 래퍼 대신 네이티브 `<button>` 태그와 `aria-disabled="true"`를 사용하여 스크린 리더 호환성을 개선하고, `onClick={(e) => e.preventDefault()}`를 적용하여 동작을 막으면서도 `title` 툴팁과 키보드 포커스가 작동하도록 수정했습니다. 또한, `aria-disabled` 상태에 대응하는 CSS(Tailwind) 스타일 변형을 추가했습니다.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Github Actions의 macOS 환경에서 `create-dmg`가 없거나 서명 문제로 발생하는 dmg 번들링 실패를 회피하기 위해, `--bundles dmg` 옵션을 `--bundles app`으로 수정했습니다.
Github Actions의 macOS 환경에서 `.dmg` 빌드 시 발생하는 `create-dmg` 및 서명 오류를 회피하기 위해 `build-baseline.yml`에서 `--bundles dmg`를 `--bundles app`으로 수정했습니다. 이에 맞추어, 아티팩트 패키징 스크립트(`scripts/release/package_desktop_artifact.py`)가 `.app` 확장자를 가진 '디렉토리'를 올바르게 찾고 `.zip` 파일로 압축한 후 SHA-256 체크섬을 생성하도록 개선했습니다.
`aria-disabled="true"`가 부여된 네이티브 버튼이 `disabled` 속성과 달리 클릭이나 엔터, 스페이스바 입력을 무시하지 않고 부모 요소로 이벤트를 버블링(bubbling)하는 문제를 해결했습니다. 각 비활성화 상태의 컴포넌트에 `onClick`과 `onKeyDown`을 추가하여 `e.preventDefault()`와 함께 `e.stopPropagation()`을 호출하도록 강제하고, 이에 대한 회귀 테스트를 보강했습니다.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head7599a2a1f4ed0365b789fa189f4f20a886f62aa1. -
Head SHA:
7599a2a1f4ed0365b789fa189f4f20a886f62aa1 -
Workflow run: 29057536294
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: build-baseline.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: build-baseline.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (8 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (8 files)"]
R2 --> V2["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: build-baseline.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: build-baseline.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (8 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (8 files)"]
R2 --> V2["required checks"]
|
버튼이 `aria-disabled="true"`를 사용할 때 Space와 Enter 키 입력이 여전히 클릭 이벤트를 트리거하고, 이벤트가 부모 엘리먼트로 버블링되는 문제를 해결했습니다. 이 PR은 `onKeyDown`과 `e.stopPropagation()` 방어 로직을 추가하고, 이 동작을 보장하기 위한 유닛 테스트 커버리지 및 키보드 활성화 테스트를 제공합니다.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headce2f67bd55cec852411882db8654c399e153d406. -
Head SHA:
ce2f67bd55cec852411882db8654c399e153d406 -
Workflow run: 29058330299
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: build-baseline.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: build-baseline.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (8 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (8 files)"]
R2 --> V2["required checks"]
2 participants
이 PR은 데스크톱 앱 전반에서 비활성화된 버튼들이 잘못된 방식으로 마크업(
span role="button" tabIndex={0})되어 있던 접근성(A11y) 문제를 해결합니다.span role="button"제거 및 네이티브<button>사용.disabled속성 대신aria-disabled="true"를 사용해 구현.aria-disabled에 대응하는 TailwindButton변형(buttonVariants) 추가.onClick={(e) => e.preventDefault()}적용.App.test.tsx,Workspace.test.tsx의 테스트도 새로운 DOM 구조 및 이벤트 동작에 맞춰 업데이트했습니다.PR created automatically by Jules for task 4211322424929805196 started by @seonghobae