Skip to content

🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ #609

Closed
seonghobae wants to merge 1 commit into
developfrom
palette-a11y-disabled-tooltips-6195019187973209205
Closed

🎨 Palette: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ #609
seonghobae wants to merge 1 commit into
developfrom
palette-a11y-disabled-tooltips-6195019187973209205

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: λΉ„ν™œμ„±ν™”λœ λ„€μ΄ν‹°λΈŒ λ²„νŠΌμ— νˆ΄νŒμ„ 뢙이기 μœ„ν•΄ μ‚¬μš©λ˜λ˜ span role="button" 감싸기 νŒ¨ν„΄μ„ μ œκ±°ν•˜κ³ , λ„€μ΄ν‹°λΈŒ <button>에 aria-disabled="true"와 onClick={(e) => e.preventDefault()}λ₯Ό μ‚¬μš©ν•˜λŠ” νŒ¨ν„΄μœΌλ‘œ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why: κΈ°μ‘΄ 방식은 슀크린 λ¦¬λ”μ—κ²Œ μ€‘μ²©λœ μƒν˜Έμž‘μš© μš”μ†Œλ₯Ό μ œκ³΅ν•˜μ—¬ 접근성을 μ €ν•΄ν•˜λŠ” μ•ˆν‹° νŒ¨ν„΄μ΄μ—ˆμŠ΅λ‹ˆλ‹€. μ˜¬λ°”λ₯Έ ARIA νŒ¨ν„΄μœΌλ‘œ λ§ˆμ΄κ·Έλ ˆμ΄μ…˜ν•˜μ—¬ 슀크린 리더 및 ν‚€λ³΄λ“œ 접근성을 λͺ¨λ‘ 보μž₯ν•©λ‹ˆλ‹€.

β™Ώ Accessibility:

  • 잘λͺ»λœ role="button" 쀑첩 제거
  • aria-disabled="true" 및 μ‹œκ°μ  λΉ„ν™œμ„±ν™” μŠ€νƒ€μΌ(opacity-50, cursor-not-allowed) 보μž₯
  • title 툴팁이 λ„€μ΄ν‹°λΈŒ μš”μ†Œμ—μ„œ μ˜¬λ°”λ₯΄κ²Œ μž‘λ™ν•˜λ„λ‘ pointer-events-none 제거 및 클릭 차단(e.preventDefault()) 적용

PR created automatically by Jules for task 6195019187973209205 started by @seonghobae

λΉ„ν™œμ„±ν™”λœ μš”μ†Œμ— νˆ΄νŒμ„ μΆ”κ°€ν•˜κΈ° μœ„ν•΄ `span role="button"`으둜 κ°μ‹ΈλŠ” μ•ˆν‹° νŒ¨ν„΄μ„ μ œκ±°ν•˜κ³ ,
λ„€μ΄ν‹°λΈŒ `<button>`에 `aria-disabled="true"`λ₯Ό μ μš©ν•˜λŠ” μ˜¬λ°”λ₯Έ μ ‘κ·Όμ„± νŒ¨ν„΄μœΌλ‘œ λ§ˆμ΄κ·Έλ ˆμ΄μ…˜ν–ˆμŠ΅λ‹ˆλ‹€.

- `apps/desktop/src/App.tsx`: Settings 및 Help λ²„νŠΌ κ°œμ„ . Save Project λ²„νŠΌμ„ `<Button>` μ»΄ν¬λ„ŒνŠΈλ‘œ λ³€κ²½.
- `apps/desktop/src/features/workspace/Workspace.tsx`: Play stem λ“± μ•‘μ…˜ λ²„νŠΌμ˜ 래퍼 제거.
- `.Jules/palette.md`: λ„€μ΄ν‹°λΈŒ λ²„νŠΌ 접근성에 λŒ€ν•œ λŸ¬λ‹ 기둝 μΆ”κ°€.
- `App.test.tsx`, `Workspace.test.tsx`: λ³€κ²½λœ ꡬ쑰에 맞게 `createEvent.click`을 μ‚¬μš©ν•˜μ—¬ ν…ŒμŠ€νŠΈ 검증 및 컀버리지 100% μœ μ§€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@opencode-agent

opencode-agent Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 7253a3b5cb2830fa2c97a8d1abd1268816dc2118
  • Workflow run: 28917383258
  • Workflow attempt: 1
  • Gate result: APPROVE (exit 0)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (5 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (5 files)"]
  R1 --> V1["required checks"]
Loading

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Superseded by #634. The useful disabled-button accessibility direction has been consolidated there; this branch is DIRTY and, against current develop, carries a stale broad snapshot that would delete or revert large parts of the product tree.

@google-labs-jules

Copy link
Copy Markdown

Superseded by #634. The useful disabled-button accessibility direction has been consolidated there; this branch is DIRTY and, against current develop, carries a stale broad snapshot that would delete or revert large parts of the product tree.

Understood. Acknowledging that this work is now obsolete as it has been superseded by #634, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant