Skip to content

🎨 Palette: EventList RowView의 ν‚€λ³΄λ“œ μ ‘κ·Όμ„± 및 μ‹œλ§¨ν‹± ν–₯상#246

Open
seonghobae wants to merge 1 commit into
developmentalfrom
palette/ux-event-list-a11y-17560178948129585111
Open

🎨 Palette: EventList RowView의 ν‚€λ³΄λ“œ μ ‘κ·Όμ„± 및 μ‹œλ§¨ν‹± ν–₯상#246
seonghobae wants to merge 1 commit into
developmentalfrom
palette/ux-event-list-a11y-17560178948129585111

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What: EventList μ»΄ν¬λ„ŒνŠΈ λ‚΄λΆ€μ˜ RowView λ²„νŠΌμ— focus-visible μŠ€νƒ€μΌκ³Ό aria-current, aria-expanded 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: νƒ€μž„λΌμΈμ—μ„œ 이벀트λ₯Ό ν‚€λ³΄λ“œλ‘œ 탐색할 λ•Œ ν˜„μž¬ 포컀슀된 μœ„μΉ˜λ₯Ό μ‹œκ°μ μœΌλ‘œ μ•Œ 수 μ—†μ—ˆμœΌλ©°, 슀크린 리더 μ‚¬μš©μžμ—κ²Œ ν˜„μž¬ μ„ νƒλœ μ΄λ²€νŠΈμΈμ§€, ν•˜μœ„ ν•­λͺ©μ΄ 펼쳐져 μžˆλŠ”μ§€μ— λŒ€ν•œ μƒνƒœ 정보가 λΆ€μ‘±ν–ˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: ν‚€λ³΄λ“œ Tab 이동 μ‹œ 링이 μ˜¬λ°”λ₯΄κ²Œ ν‘œμ‹œλ©λ‹ˆλ‹€.
β™Ώ Accessibility:

  • λͺ…μ‹œμ μΈ 포컀슀 ν‘œμ‹œ (focus-visible:ring-2)
  • ν˜„μž¬ ν•­λͺ© ν‘œμ‹œ (aria-current="step")
  • ν™•μž₯ κ°€λŠ₯ μ˜μ—­ μƒνƒœ 제곡 (aria-expanded)

PR created automatically by Jules for task 17560178948129585111 started by @seonghobae

- `focus-visible` μœ ν‹Έλ¦¬ν‹° 클래슀λ₯Ό μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ 탐색 μ‹œ(Tab) 포컀슀 링이 λͺ…ν™•ν•˜κ²Œ ν‘œμ‹œλ˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€. (마우슀 클릭 μ‹œμ—λŠ” λΆˆν•„μš”ν•œ 포컀슀 링이 생기지 μ•ŠμŠ΅λ‹ˆλ‹€.)
- `aria-current="step"`을 μΆ”κ°€ν•˜μ—¬ ν˜„μž¬ μ„ νƒλœ 이벀트λ₯Ό 슀크린 λ¦¬λ”μ—μ„œ 논리적인 'ν˜„μž¬ 단계'둜 인식할 수 있게 ν–ˆμŠ΅λ‹ˆλ‹€.
- κ·Έλ£Ή ν—€λ”μ˜ 경우 `aria-expanded` 속성을 μΆ”κ°€ν•˜μ—¬ 펼침/μ ‘νž˜ μƒνƒœλ₯Ό 슀크린 리더 μ‚¬μš©μžμ—κ²Œ μ œκ³΅ν•©λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant