π¨ Palette: [UX improvement] Context Section μ»΄ν¬λνΈ μ κ·Όμ± κ°μ #244
π¨ Palette: [UX improvement] Context Section μ»΄ν¬λνΈ μ κ·Όμ± κ°μ #244seonghobae wants to merge 2 commits into
Conversation
- Add `useId()` to dynamically generate ARIA relation IDs - Link button and region with `aria-controls`, `id`, and `aria-labelledby` - Hide chevron icons from screen readers using `aria-hidden="true"` - Add `focus-visible` classes to button to display focus rings for keyboard navigation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What
ContextSectionμ»΄ν¬λνΈ λ΄μ μμ½λμΈ ν κΈ λ²νΌμ ν€λ³΄λ νμ ν¬μ»€μ€ μ€νμΌ(focus-visible)μ μΆκ°νκ³ , μ€ν¬λ¦° 리λ μ¬μ©μλ₯Ό μν΄ WAI-ARIA μμ±(aria-controls,aria-labelledby,role="region")μ μ¬λ°λ₯΄κ² λ§€ννμ΅λλ€.π― Why
κΈ°μ‘΄
ContextSectionμ»΄ν¬λνΈλ λ§μ°μ€ μ κ·Όμλ λ¬Έμ κ° μμμΌλ, ν ν€λ₯Ό ν΅ν ν€λ³΄λ νμ μ ν¬μ»€μ€ λ§μ΄ νμλμ§ μμ μ΄λ μμμ μμΉν΄ μλμ§ μκ°μ μΈ νΌλλ°±μ΄ λΆμ‘±νμ΅λλ€. λν μ€ν¬λ¦° 리λ μ¬μ©μμκ² ν κΈ λ²νΌκ³Ό νΌμ³μ§λ λ΄μ© μ¬μ΄μ μ°κ΄μ±μ μλ―Έμ μΌλ‘ μ 곡νμ§ μμμ΅λλ€.πΈ Before/After
(Playwright μμ/μ€ν¬λ¦°μ· κ²μ¦ μλ£)
aria-labelledbyμμ± λΆμ¬ring-2 ring-ring), ν κΈ λ²νΌκ³Ό ν¨λ 컨ν μΈ κ° κ³ μ IDλ₯Ό ν΅ν΄ ARIA μμ±μΌλ‘ μ°κ²°λ¨βΏ Accessibility
useIdν μ λμ νμ¬ κ³ μ ν IDλ₯Ό λΆμ¬ν¨μΌλ‘μ¨, ν νμ΄μ§μ μ¬λ¬ContextSectionμ΄ μ¬μ©λλλΌλ μ€ν¬λ¦° 리λκ° λ²νΌκ³Ό ν΄λΉ λ΄μ© μμμ μ ννκ² λ§€ν(aria-controls,aria-labelledby)ν μ μκ² λμμ΅λλ€.role="region"μ ν λΉνμ¬ μ€ν¬λ¦° 리λκ° λͺ νν μμ λλλ§ν¬λ‘ μΈμνλλ‘ κ°μ νμ΅λλ€.aria-hidden="true"μμ±μ μΆκ°νμ¬ μ€ν¬λ¦° 리λκ° λΆνμνκ² μ½μ§ μλλ‘ μ‘°μΉνμ΅λλ€.focus-visible:ring-2) μ§μμ μΆκ°νμ¬ μκ°μ μ κ·Όμ±μ κ°ννμ΅λλ€.PR created automatically by Jules for task 7948769173390846838 started by @seonghobae