Skip to content

🎨 Palette: [UX improvement] Enhance ContextSection accessibility#243

Open
seonghobae wants to merge 4 commits into
developmentalfrom
feature/ux-context-section-a11y-7873474212620094974
Open

🎨 Palette: [UX improvement] Enhance ContextSection accessibility#243
seonghobae wants to merge 4 commits into
developmentalfrom
feature/ux-context-section-a11y-7873474212620094974

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What

  • ContextSection μ»΄ν¬λ„ŒνŠΈμ˜ ν† κΈ€ λ²„νŠΌμ— λͺ…ν™•ν•œ ν‚€λ³΄λ“œ 포컀슀 μŠ€νƒ€μΌ(focus-visible)을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • React의 useId() 훅을 μ‚¬μš©ν•˜μ—¬ λ²„νŠΌκ³Ό μ½˜ν…μΈ  μ˜μ—­ κ°„μ˜ aria-controls 및 id 연결을 λ™μ μœΌλ‘œ μƒμ„±ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

  • ν‚€λ³΄λ“œ μ ‘κ·Όμ„±: κΈ°μ‘΄ ν† κΈ€ λ²„νŠΌμ€ ν‚€λ³΄λ“œ(Tab ν‚€)둜 탐색 μ‹œ 포컀슀 μƒνƒœκ°€ λͺ…ν™•ν•˜κ²Œ 보이지 μ•Šμ•„ μ–΄λ–€ μš”μ†Œκ°€ μ„ νƒλ˜μ—ˆλŠ”μ§€ μ•ŒκΈ° μ–΄λ €μ› μŠ΅λ‹ˆλ‹€.
  • 슀크린 리더 ν˜Έν™˜μ„±: ν•˜λ‚˜μ˜ νŽ˜μ΄μ§€μ— μ—¬λŸ¬ ContextSection이 μ‘΄μž¬ν•  λ•Œ ν•˜λ“œμ½”λ”©λœ ID둜 인해 λ°œμƒν•  수 μžˆλŠ” μΆ©λŒμ„ λ°©μ§€ν•˜κ³ , 슀크린 리더가 λ²„νŠΌκ³Ό μˆ¨κ²¨μ§„ μ½˜ν…μΈ  κ°„μ˜ 논리적 연결을 μ •ν™•νžˆ νŒŒμ•…ν•  수 μžˆλ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

  • Playwright μ‹œκ°μ  확인을 톡해 포컀슀 μŠ€νƒ€μΌ(ring-2)이 μ μš©λ¨μ„ 확인 μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€.

β™Ώ Accessibility

  • aria-controls 및 고유 id λΆ€μ—¬ (슀크린 리더 λ„€λΉ„κ²Œμ΄μ…˜ ν–₯상)
  • focus-visible:ring-2 λ“± μœ ν‹Έλ¦¬ν‹° 클래슀 μΆ”κ°€ (ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ μ‹œμΈμ„± ν–₯상)

PR created automatically by Jules for task 7873474212620094974 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant