ci: run @argos/shared tests in CI#240
Open
seonghobae wants to merge 3 commits into
Open
Conversation
The shared package's vitest suite (pricing cost math, auth/events/project zod schemas — 42 tests) existed but was never invoked: ci.yml only ran argos-ai and @argos/web tests. Regressions in cost calculation or request validation shipped ungated. Verified locally: 42/42 pass in ~1s. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMkMUa1c1RRsbHEfsQUhui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A test-coverage audit found that
packages/shared's vitest suite — 42 tests covering the pricing/cost math (src/constants/pricing.test.ts) and the auth/events/project zod schemas — was never invoked by CI:ci.ymlranargos-aiand@argos/webtests only, so regressions in cost calculation or request validation shipped ungated.This adds one step:
pnpm --filter @argos/shared test.Verification
Ran locally after
pnpm install --frozen-lockfile: 4 test files, 42/42 passed in ~1.1s. No DB or env vars required.🤖 Generated with Claude Code
https://claude.ai/code/session_01AMkMUa1c1RRsbHEfsQUhui
Generated by Claude Code