๐จ Palette: [UX improvement] ์ปค์คํ ๋ฆฌ์คํธ ํ ํค๋ณด๋ ์ ๊ทผ์ฑ ๋ฐ ARIA ์์ฑ ๊ฐ์ #232
Conversation
EventList ์ปดํฌ๋ํธ ๋ด๋ถ์ RowView ํ ๋ฒํผ์ ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ ๋ช ํํ ํฌ์ปค์ค ์์น๋ฅผ ๋ณด์ฌ์ฃผ๋ `focus-visible` ์คํ์ผ์ ์ถ๊ฐํ์ต๋๋ค. ๋ํ ์ ๊ธฐ/ํผ์น๊ธฐ ์์์ `aria-expanded` ์์ฑ์ ์ถ๊ฐํ๊ณ , ์ฅ์์ฉ ์์ด์ฝ์ `aria-hidden` ์ฒ๋ฆฌํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋ ๊ฒฝํ์ ๊ฐ์ ํ์ต๋๋ค.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
๐ก What
EventList์ปดํฌ๋ํธ ๋ด๋ถ์RowView(์ด๋ฒคํธ ๋ชฉ๋ก ํ ๋ฒํผ)์ ํค๋ณด๋ ํฌ์ปค์ค ๋ง ์คํ์ผ๊ณผ ๋ช ์์ ์ธ ARIA ์ ๊ทผ์ฑ ์์ฑ์ ์ถ๊ฐํ์ต๋๋ค.๐ฏ Why
์ด๋ฒคํธ ๋ชฉ๋ก ํ์
<button>์์๋ก ๊ตฌํ๋์ด ์์ผ๋, Tailwind์ reset์ผ๋ก ์ธํด ๊ธฐ๋ณธ ๋ธ๋ผ์ฐ์ ํฌ์ปค์ค ๋ง์ด ์ ๊ฑฐ๋ ์ํ์์ต๋๋ค. ์ด๋ก ์ธํด ํญ(Tab) ํค๋ก ๋ด๋น๊ฒ์ด์ ํ๋ ํค๋ณด๋ ์ฌ์ฉ์์๊ฒ ํ์ฌ ํฌ์ปค์ค ์์น๋ฅผ ๋ณด์ฌ์ฃผ์ง ๋ชปํ์ต๋๋ค. ๋ํ ๊ทธ๋ฃนํ๋ ์ด๋ฒคํธ๋ฅผ ํผ์น๊ฑฐ๋ ์ ๋ ํ์ ๊ฒฝ์ฐ, ์คํฌ๋ฆฐ ๋ฆฌ๋๊ฐ ์ํ๋ฅผ ๋ช ํํ ์ ์ ์๋๋กaria-expanded๊ฐ ํ์ํ์ต๋๋ค.๐ธ Before/After
(Screenshots and videos recorded locally via Playwright show the new
ring-2focus indicator functioning on the list items during Tab navigation).โฟ Accessibility
focus-visible:outline-none,focus-visible:ring-2,focus-visible:ring-inset,focus-visible:bg-muted/50์ ํธ๋ฆฌํฐ๋ฅผ ์ ์ฉํ์ฌ ํค๋ณด๋ ์ ๊ทผ์ฑ(Focus Indicators) ๊ฐ์aria-expanded์์ฑ ๋์ ๋ฐ์ธ๋ฉ ์ถ๊ฐ<Icon />๋ฐ<ChevronRight />๋ฑ ์๊ฐ์ ์ฅ์์ฉ ์์ด์ฝ์aria-hidden="true"๋ฅผ ๋ถ์ฌํ์ฌ ๋ถํ์ํ ์คํฌ๋ฆฐ ๋ฆฌ๋ ๋ ธ์ด์ฆ ์ ๊ฑฐPR created automatically by Jules for task 13291480688213298242 started by @seonghobae