Skip to content

🎨 Palette: [UX improvement] Enhance ContextSection accordion accessibility#227

Open
seonghobae wants to merge 1 commit into
developmentalfrom
palette/accordion-a11y-9653655898456636776
Open

🎨 Palette: [UX improvement] Enhance ContextSection accordion accessibility#227
seonghobae wants to merge 1 commit into
developmentalfrom
palette/accordion-a11y-9653655898456636776

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What:

  • ContextSection μ»΄ν¬λ„ŒνŠΈ(μ•„μ½”λ””μ–Έ)에 μ ‘κ·Όμ„± ν–₯상을 μœ„ν•œ ARIA 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν‚€λ³΄λ“œ 탐색 μ‚¬μš©μžλ₯Ό μœ„ν•΄ 포컀슀 μ‹œ μ‹œκ°μ  ν”Όλ“œλ°±μ΄ λͺ…ν™•νžˆ 보이도둝 focus-visible μŠ€νƒ€μΌμ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • κ΄€λ ¨ ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μž‘μ„±ν•˜μ—¬ 100% ν…ŒμŠ€νŠΈ 컀버리지λ₯Ό 보μž₯ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why:

  • 슀크린 리더 μ‚¬μš©μžκ°€ μ•„μ½”λ””μ–Έ ν† κΈ€ λ²„νŠΌκ³Ό μ—΄λ¦¬λŠ” νŒ¨λ„μ΄ μ„œλ‘œ μ—°κ²°λ˜μ–΄ μžˆμŒμ„ μΈμ§€ν•˜κ³  λ‚΄μš©μ„ μ‰½κ²Œ νŒŒμ•…ν•  수 μžˆμ–΄μ•Ό ν•©λ‹ˆλ‹€.
  • ν‚€λ³΄λ“œ 이동 μ‹œ ν˜„μž¬ 포컀슀된 μš”μ†Œλ₯Ό μ§κ΄€μ μœΌλ‘œ 확인할 수 μžˆμ–΄μ•Ό μ‚¬μš©μ„±μ΄ κ°œμ„ λ©λ‹ˆλ‹€.

πŸ“Έ Before/After:

  • λ³€κ²½ μ „: κΈ°λ³Έ <button>을 μ‚¬μš©ν•΄ 슀크린 λ¦¬λ”μ—μ„œ λ‚΄μš©κ³Όμ˜ 연결성이 λΆ€μ‘±ν–ˆμœΌλ©°, 포컀슀 μ‹œ λšœλ ·ν•œ 외곽선이 μ—†μ—ˆμŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ ν›„: aria-controls, role="region", aria-labelledby λ“± W3C ꢌμž₯ 속성이 μΆ”κ°€λ˜μ—ˆμœΌλ©° 포컀슀 μ‹œ λͺ…ν™•ν•œ 링 μŠ€νƒ€μΌμ΄ λ…ΈμΆœλ©λ‹ˆλ‹€.

β™Ώ Accessibility:

  • 동적인 μ»΄ν¬λ„ŒνŠΈ μΈμŠ€ν„΄μŠ€λ§ˆλ‹€ κ²ΉμΉ˜μ§€ μ•ŠλŠ” ID 생성을 μœ„ν•΄ useId() 훅을 μ μš©ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ»΄ν¬λ„ŒνŠΈ ν…ŒμŠ€νŠΈ μŠ€μœ„νŠΈλ₯Ό μΆ”κ°€ν•΄ ν‚€λ³΄λ“œ μΈν„°λž™μ…˜κ³Ό μ ‘κ·Όμ„± 속성 μƒνƒœ λ³€ν™”λ₯Ό κ²€μ¦ν•©λ‹ˆλ‹€.

PR created automatically by Jules for task 9653655898456636776 started by @seonghobae

…collapsible

- Added useId() for generating unique DOM IDs
- Connected accordion toggle and content panel with aria-controls, role="region" and aria-labelledby
- Improved keyboard navigation with focus-visible styling
- Added unit tests for ContextSection component
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant