Skip to content

🎨 Palette: λŒ€μ‹œλ³΄λ“œ μ ‘κ·Όμ„± κ°œμ„  (ν‚€λ³΄λ“œ 탐색 지원)#263

Open
seonghobae wants to merge 1 commit into
developfrom
palette-dashboard-a11y-3299793512983139065
Open

🎨 Palette: λŒ€μ‹œλ³΄λ“œ μ ‘κ·Όμ„± κ°œμ„  (ν‚€λ³΄λ“œ 탐색 지원)#263
seonghobae wants to merge 1 commit into
developfrom
palette-dashboard-a11y-3299793512983139065

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: λŒ€μ‹œλ³΄λ“œ(scanner/dashboard/index.html)의 ν…Œμ΄λΈ” ν–‰(Findings λͺ©λ‘)에 ν‚€λ³΄λ“œ μ ‘κ·Όμ„± 및 슀크린 리더 지원을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: κΈ°μ‘΄ ν…Œμ΄λΈ” 행은 클릭 이벀트λ₯Ό 톡해 상세 정보λ₯Ό λ³Ό 수 μžˆμ—ˆμ§€λ§Œ, tabindex와 ν‚€λ³΄λ“œ 이벀트 μ²˜λ¦¬κ°€ λˆ„λ½λ˜μ–΄ μžˆμ–΄ ν‚€λ³΄λ“œ μ „μš© μ‚¬μš©μžλ‚˜ 슀크린 리더 μ‚¬μš©μžκ°€ μ ‘κ·Όν•  수 μ—†λŠ” λ¬Έμ œκ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: μ‹œκ°μ μœΌλ‘œλŠ” :focus-visible μƒνƒœμΌ λ•Œ ν˜Έλ²„μ™€ λ™μΌν•œ 배경색 및 μ „μ—­ 포컀슀 링이 ν‘œμ‹œλ©λ‹ˆλ‹€.
β™Ώ Accessibility:

  • 검색창 및 선택 λͺ©λ‘μ— aria-label μΆ”κ°€
  • ν…Œμ΄λΈ” 행에 tabindex="0" λΆ€μ—¬
  • ν…Œμ΄λΈ” 행에 keydown 이벀트 μΆ”κ°€ (Enter/Space 지원)
  • :focus-visible μƒνƒœ μŠ€νƒ€μΌ μΆ”κ°€λ‘œ 포컀슀 이동 κ°€μ‹œμ„± ν–₯상

PR created automatically by Jules for task 3299793512983139065 started by @seonghobae

- μ „μ—­ `:focus-visible` CSS κ·œμΉ™μ„ μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ 포컀슀 μ‹œκ°μ  ν”Όλ“œλ°± κ°œμ„ 
- `tbody tr`에 ν˜Έλ²„ 및 포컀슀(`:focus-visible`) μƒνƒœ μŠ€νƒ€μΌ 적용
- 슀크린 리더 지원을 μœ„ν•΄ 검색 μž…λ ₯μ°½ 및 μ€‘μš”λ„ 선택 λͺ©λ‘μ— `aria-label` 속성 μΆ”κ°€
- μƒν˜Έμž‘μš© κ°€λŠ₯ν•œ ν…Œμ΄λΈ” ν–‰(`<tr>`)에 `tabindex="0"` μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ 포컀슀 지원
- ν…Œμ΄λΈ” 행에 `keydown` 이벀트 λ¦¬μŠ€λ„ˆλ₯Ό μΆ”κ°€ν•˜μ—¬ `Enter` 및 `Space` ν‚€λ‘œ 상세 정보 λŒ€ν™”μƒμžλ₯Ό μ—΄ 수 μžˆλ„λ‘ κ°œμ„ 
- `.Jules/palette.md`에 μΈν„°λž™ν‹°λΈŒ ν…Œμ΄λΈ” ν–‰μ˜ ν‚€λ³΄λ“œ μ ‘κ·Όμ„± κ΄€λ ¨ ν•™μŠ΅ λ‚΄μš© μΆ”κ°€
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant