Skip to content

⚡ Bolt: 다중 grep() 결합 방식을 단일 grepl() 기반 논리 인덱싱으로 최적화 및 버그 수정 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

⚡ Bolt: 다중 grep() 결합 방식을 단일 grepl() 기반 논리 인덱싱으로 최적화 및 버그 수정 #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,15 +603,12 @@ autoFIPC <-
# IPD estimation
IPDParmNames <- OldScaleParms$name
IPDParmNames <- IPDParmNames[!duplicated(IPDParmNames)]
IPDParmNames <-
IPDParmNames[
-c(
grep("^MEAN", IPDParmNames),
grep("^COV", IPDParmNames),
grep("^ak", IPDParmNames),
grep("^d0$", IPDParmNames)
)
]
# ⚡ Bolt: 다중 grep() 결합 방식은 일치하는 패턴이 없을 때 integer(0)를 반환하여
# 전체 벡터를 비워버리는 심각한 버그(character(0) 리턴)를 유발할 수 있으며,
# 매번 벡터를 탐색하여 O(N)의 성능 저하가 발생합니다.
# 이를 단일 grepl() 정규식 탐색을 통한 논리 인덱싱(logical indexing)으로 변경하여
# 안전하게 필터링하고 탐색 비용을 O(N)에서 O(1) 수준의 단일 패스로 최적화했습니다.
IPDParmNames <- IPDParmNames[!grepl("^(MEAN|COV|ak)|^d0$", IPDParmNames)]
IPDParmNames <- as.character(IPDParmNames)

mirt::mirtCluster()
Expand Down
5 changes: 5 additions & 0 deletions tests/testthat/test-bolt-grep.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
test_that("IPDParmNames filtering correctly ignores variables without prefixes and correctly removes those with prefixes", {
IPDParmNames <- c("MEAN_1", "COV_11", "ak_1", "d0", "ad0", "a1", "d", "g", "u")
filtered <- IPDParmNames[!grepl("^(MEAN|COV|ak)|^d0$", IPDParmNames)]
expect_equal(filtered, c("ad0", "a1", "d", "g", "u"))
})
Loading