Skip to content

fix: memory dedup race and episode end time going backwards #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeybe1kin merged 3 commits into from
Nov 3, 2026
Merged

fix: memory dedup race and episode end time going backwards #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a24b67
fix: TOCTOU in exact-match dedup creates duplicate memories
alexeybe1kin Nov 3, 2026
6e178e0
fix: episode.occurred_end overwritten with earlier or None timestamp
alexeybe1kin Nov 3, 2026
99ca59b
review: make the dedup advisory lock valid Postgres and skip it on SQ…
alexeybe1kin Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions services/api/app/services/runtime_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from app.services.processing_lease import LeaseHeartbeat, LeaseLostError, fence_job_lease
from app.services.signal_filter import score_value
from app.services.vector_outbox import enqueue_upsert
from sqlalchemy import select
from sqlalchemy import select, text


def _link(db, source_type, source_id, target_type, target_id, relationship, confidence=1.0):
Expand Down Expand Up @@ -72,7 +72,8 @@ def process_evidence(
db.add(episode)
db.flush()
else:
episode.occurred_end = evidence.occurred_at
if evidence.occurred_at is not None and (episode.occurred_end is None or evidence.occurred_at > episode.occurred_end):
episode.occurred_end = evidence.occurred_at
_link(db, "evidence", evidence.id, "episode", episode.id, "grouped_into", evidence.integrity_confidence)

job.stage = "analysis"
Expand Down Expand Up @@ -111,6 +112,12 @@ def process_evidence(
indexing = {"status": "ok"}
if value >= 0.3:
# Case-insensitive exact match: reuse the stored memory when the listener text is already there.
if db.get_bind().dialect.name == "postgresql":
# Serialise concurrent promotions of the same text until this transaction commits.
db.execute(
text("SELECT pg_advisory_xact_lock(hashtext(:agent_id), hashtext(:memory_text))"),
{"agent_id": evidence.agent_id, "memory_text": content.strip().lower()},
)
memory = db.execute(select(Memory).where(Memory.agent_id == evidence.agent_id, Memory.text.ilike(escape_like(content.strip()), escape="/"))).scalars().first()
if not memory:
memory = Memory(
Expand Down
Loading