feat(storage): rewrite GCS provider to IStorageProvider parity#1509
Open
kkopanidis wants to merge 1 commit into
Open
feat(storage): rewrite GCS provider to IStorageProvider parity#1509kkopanidis wants to merge 1 commit into
kkopanidis wants to merge 1 commit into
Conversation
Replace the deprecated Google Cloud Storage provider with a full implementation aligned to AWS S3 and Azure, including UBLA-safe IAM public access, v4 signed URLs, ADC/inline JSON auth, and fixes for deleteContainer, deleteFolder, exists, getSignedUrl, and folder markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Google Cloud Storage provider was deprecated and missing critical
IStorageProvidermethods. This rewrites it to parity with AWS S3 and Azure.Problems fixed:
deleteContaineranddeleteFolderthrew "not implemented"getSignedUrlnever returned a valueexistsalways returnedtruename/keep.txtinstead of the sharedname.keep.txtconventionmakePublic/makePrivate) incompatible with Uniform Bucket-Level AccessWhat changed:
IStorageProviderimplementation with metrics parity (containers_total,folders_totalincrement/decrement)google.serviceAccountKeyJson), or Application Default Credentialsroles/storage.objectViewerforallUsers)Test plan
googlewith a GCS bucket (or fake-gcs-server emulator)createContainer(public + private),containerExists,setContainerPublicAccess,deleteContainercreateFolder,folderExists(marker at{folder}.keep.txt),deleteFolderremoves marker and prefixed objectsstore,get,exists(returnsfalsefor missing files),deletegetSignedUrlreturns a working v4 URL;getUploadUrlaccepts PUT;getPublicUrlreturns direct URL for public buckets and signed URL for private bucketscontainers_total/folders_totalincrement on create and decrement on delete