feat(functions): implement cron scheduling with BullMQ#1507
Open
kkopanidis wants to merge 1 commit into
Open
Conversation
Cron functions now register repeatable BullMQ jobs instead of erroneously subscribing to the event bus, with pattern validation and execution logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
functionType: 'cron'was accepted by the admin API and UI but never ran on a schedule. The runtime fell through to the event-bus path and subscribed to a channel named after the cron expression, so scheduled functions silently never executed.Summary
functions-cron-queuewith idempotentsyncCronJobs()on everyrefreshRoutes()cron-{functionId}); orphan cleanup on delete/type changeinputs.cronPatternwith legacyinputs.eventalias; admin validation on upload/patchFunctionExecutions, and existing metricsinputs.event→inputs.cronPatternfor existing cron docsWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchIf adding a new feature, the PR's description includes:
Test plan
*/5 * * * *); confirmFunctionExecutionsrecords appear within ~5 minutesfunctionType: 'event'still subscribes to the bus (no regression)active: false; confirm queue drains and ticks stop