feat(functions): cron schedule field maps to cronPattern#286
Merged
Conversation
Create and edit forms now send inputs.cronPattern, validate 5-field UTC schedules client-side, and load legacy inputs.event values on edit.
d34a1fc to
00a9a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The functions UI collected a cron schedule but stored it only as
inputs.event. The backend now expects canonicalinputs.cronPattern, and invalid patterns were accepted without client-side feedback.Summary
cronString→inputs.cronPattern(keepsinputs.eventas alias for transition)inputs.cronPattern ?? inputs.eventcron-parserminute hour day month weekday (UTC)What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
ui-rewritebranchIf adding a new feature, the PR's description includes:
Test plan
*/5 * * * *; confirm API payload includesinputs.cronPatternnot a cron); confirm inline validation errorinputs.event; confirm field pre-fills