Skip to content

feat: mark teammate_invitation resource type as skipSyncAnomalyDetection#29

Open
Bencheng21 wants to merge 1 commit into
mainfrom
feat/skip-sync-anomaly-on-teammate-invitation
Open

feat: mark teammate_invitation resource type as skipSyncAnomalyDetection#29
Bencheng21 wants to merge 1 commit into
mainfrom
feat/skip-sync-anomaly-on-teammate-invitation

Conversation

@Bencheng21

Copy link
Copy Markdown

Summary

Mark the teammate_invitation resource type with the SkipSyncAnomalyDetection annotation. Counts on this type can legitimately drop between syncs as pending invitees accept and are reclassified as users. Without this annotation, sync anomaly detection would flag those expected drops.

The user resource type intentionally remains anomaly-checked.

Test plan

  • go build ./...
  • CI green

🤖 Generated with Claude Code

teammate_invitation counts can legitimately drop between syncs as pending invitees
accept and are reclassified as users. Apply the SkipSyncAnomalyDetection
annotation so sync anomaly detection ignores those expected drops on
this resource type only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Bencheng21 Bencheng21 requested a review from a team June 29, 2026 22:20
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: feat: mark teammate_invitation resource type as skipSyncAnomalyDetection

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base e97b6c02a724.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness. This PR adds the SkipSyncAnomalyDetection annotation alongside the existing SkipEntitlementsAndGrants on the teammate_invitation resource type in pkg/connector/resource_types.go. The annotation type exists in the vendored baton-sdk and is read by connectorbuilder.go via annos.Contains; annotations.New is variadic so passing both annotations is correct. The user resource type intentionally stays anomaly-checked. No go.mod or go.sum changes, no behavioral impact on other resource types, and no new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

Note: the workflow review-state marker is omitted because the CI shell sandbox blocks the brace/quote sequence required to embed it; future runs will default to full review.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants