Repository navigation
chore(deps): bump @conduction/nextcloud-vue from 2.65.0 to 2.73.1 - #1291
Conversation
The release build runs npm ci, so it bundles the version in the lock. 2.73.1 carries nextcloud-vue#1390: the page-size selector of an index page works again, and the Related panel of a detail page opens the related object and shows names instead of uuids. The floor in package.json moves with it, so an install can never resolve below the version that has those fixes. The lock also drops "dev": true from five optional platform binaries; that is the newer npm writing the lock, not a dependency change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
WilcoLouwerse
left a comment
There was a problem hiding this comment.
Verdict: APPROVE (self-review, posted as a comment)
Mode Quick, size XS (2 files, 22 lines); read inline, no analysis agent. The lock moves @conduction/nextcloud-vue from 2.65.0 to 2.73.1 (registry tarball and integrity), the package.json floor to ^2.73.1, and no other dependency changes; the five dropped "dev": true flags are on optional platform binaries and come from the newer npm writing the lock. No findings.
Gates: local run (run-gates-on-pr.sh): exit 0, 23 of 23 applicable gates ran. The PR's own CI did not start (the pull_request event was lost during a GitHub API outage); a close/reopen or a new push will start it.
Evidence: the WOO-586 rig ran a stackiq development build against 2.73.1 for the walkthrough of 2026-10-12: page size and the Related click-through work.
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 133/133 | |||
| npm | ✅ | ✅ 807/807 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1223/1223 · 20 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-13 15:27 UTC
Download the full PDF report from the workflow artifacts.
What
The release build runs
npm ci, so it bundles the nextcloud-vue version inpackage-lock.json(2.65.0). 2.73.1 carries ConductionNL/nextcloud-vue#1390, found in the WOO-586 walkthrough:The floor in
package.jsonmoves to^2.73.1, so an install never resolves below the version with those fixes. The lock also drops"dev": truefrom five optional platform binaries; that is the newer npm writing the lock, not a dependency change.Verified
The WOO-586 rig (NC 35) ran a stackiq development build against 2.73.1 for the walkthrough: page size and the Related click-through work, names instead of uuids (walkthrough 2026-10-12).
Jira: WOO-586 — plan: https://github.com/ConductionNL/readonly-mirror-wilco-claude-plans/tree/dev-mirror/issues/jira/WOO-586/
🤖 Generated with Claude Code