This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: reverse-spec vector-embeddings capability (5 REQs)#1813
Merged
rubenvdlinde merged 1 commit intoMay 25, 2026
Conversation
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 162/162 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 06:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverse-spec retrofit that mints a new
vector-embeddingscapability and annotates the existing implementation against it. No behaviour change — annotation + spec only.The new capability documents 5 REQs, one per domain:
openregister_vectorsPHP-serialised BLOB or Solr atomic update) with UTF-8 sanitisation and entity-type-aware document IDs.VectorizationStrategyInterface, serial/parallel modes, per-entity error capture).46 methods annotated with
@specacross 7 files:lib/Service/VectorizationService.php(10)lib/Service/Vectorization/VectorEmbeddings.php(10)lib/Service/Vectorization/Handlers/EmbeddingGeneratorHandler.php(5)lib/Service/Vectorization/Handlers/VectorStorageHandler.php(6)lib/Service/Vectorization/Handlers/VectorStatsHandler.php(4)lib/Service/Vectorization/Strategies/VectorizationStrategyInterface.php(4)lib/Service/Vectorization/Strategies/ObjectVectorizationStrategy.php(7)Deferred
VectorizationService::semanticSearch/::hybridSearch,VectorEmbeddings::semanticSearch/::hybridSearch) are intentionally not annotated here — they generate the query embedding (covered by REQ-001) then delegate KNN execution toVectorSearchHandler, which thesearchcapability already owns. They will be@spec-annotated againstsearch/spec.mdonce PR retrofit: reverse-spec search partial (5 REQs / 37 methods, 111 deferred) #1791 lands.FileVectorizationStrategy(chunk handling) is a future sixth REQ once the class lands.Test plan
php -lclean on all 7 touched filestasks.mdexactly (12/8/9/7/10 per task = 46)semanticSearch/hybridSearchmethods annotated