This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: reverse-spec data-import-export (5 new REQs, Bucket 2a)#1783
Open
rubenvdlinde wants to merge 1 commit into
Open
retrofit: reverse-spec data-import-export (5 new REQs, Bucket 2a)#1783rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Ghost change retrofit-2026-05-24-data-import-export extends the data-import-export capability with 5 new REQs covering observed behaviour of 8 kept methods across 7 files (50 batch methods were pre-triaged as drops). 10 @SPEC annotations point back to the ghost change's tasks.md. - REQ-018: Import templates downloadable as empty header-only files per schema (ExportService::buildTemplateSpreadsheet/buildTemplateCsv) - REQ-019: Per-user personal data export endpoint, GDPR Art. 20 (UserController::exportData, UserService::exportPersonalData, ExportSection.vue::exportData) - REQ-020: Frontend file-type sniffing routes uploads to the correct importer by extension (ImportRegister.vue::getFileExtension) - REQ-021: Configuration import-from-source pre-flight checks API token availability (ImportConfiguration.vue::checkTokenAvailability) - REQ-022: Import/export modals reset all form state on close, plus ImportService::clearCaches resets schema-properties cache between imports (4 closeModal Vue methods + ImportService::clearCaches) Notes drifts: - Canonical spec's "NOT implemented" list still includes "Import template generation" — header-only path IS implemented (REQ-018); example-row / instructies-sheet variant remains unimplemented. - UserService::exportPersonalData returns 'objects' => [] placeholder. - checkTokenAvailability cannot distinguish revoked from configured tokens (only checks non-empty masked value). - ImportService::clearCaches only resets schemaPropertiesCache; other internal caches (validation results) are not currently cleared. Source: /tmp/or-scan/rspec-cluster-data-import-export.json — Bucket 2a (extend). No runtime behaviour changes (docblock-only).
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 162/162 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 19:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ghost change
retrofit-2026-05-24-data-import-exportextends thedata-import-exportcapability with 5 new REQs reverse-engineered from observed code. 10@specannotations point methods back to the change'stasks.md. Docblock-only; no runtime behaviour changes.ExportService::buildTemplateSpreadsheet/buildTemplateCsv)UserController::exportData,UserService::exportPersonalData,ExportSection.vue::exportData)ImportRegister.vue::getFileExtension)ImportConfiguration.vue::checkTokenAvailability)ImportService::clearCachesresets cross-import schema-properties cache (4 closeModal Vue methods +ImportService::clearCaches)Observed drifts (flagged in spec Notes)
instructiesdocumentation sheet remain unimplemented.UserService::exportPersonalDatareturns'objects' => []placeholder — owned objects aren't yet enumerated in the GDPR export envelope.checkTokenAvailabilitycannot distinguish revoked from configured tokens (only checks non-empty masked value) — failures only surface on actual search calls.ImportService::clearCachesonly resets\$schemaPropertiesCache; other internal caches (validation results) are not currently cleared by this method.Coverage
Validation
`openspec validate --changes retrofit-2026-05-24-data-import-export --strict` → pass
Test plan