Repository navigation
test(coverage): raise unit coverage past 80% and publish the measured figure - #1085
Merged
Merged
Conversation
…nd visibility rules Five tests were marked risky because their @uses lists missed classes extracted by recent refactors, so PHPUnit discarded their coverage. The missing @uses lines restore it. New tests cover the role feature permission writes, the admin-only action matrix, the admin role and template endpoints and the visibility rule evaluator. Assisted-by: ClaudeCode:claude-opus-5-5
scripts/coverage-publish.php turns the PHPUnit clover report into coverage-summary.json and the coverage line in README.md; composer coverage:publish runs the suite with coverage first. pcov is pointed at lib/, because its auto-detection picks the Vue src/ folder and would measure nothing. The committed floor moves from 49.47 to 80.00, one point under the measurement. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 11, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises launchpad's unit coverage past 80% of statements and publishes the measured figure, in the same format as the other fleet apps (
scripts/coverage-publish.php,composer coverage:publish,coverage-summary.json, the coverage line inREADME.md).@useslists missed classes that recent refactors extracted (BulkOutcome,TranslationVariantDraft,FilesWidgetAccess,ConfluenceImportRun,ParentFirstPageOrder). PHPUnit discarded their coverage, and withfailOnRiskythe suite exited 1 whenever a coverage driver was loaded. The missing@useslines fix both.coverage:publishpasses-d pcov.directory=lib: pcov's auto-detection picks the Vuesrc/folder and then measures 0%..coverage-baselinemoves from 49.47 to 80.00, one point under the measurement.Measured
PHP: 81.0% of statements (17,784 of 21,952), 2,802 tests, pcov 1.0.12 on PHP 8.3, at
b3fd2179. Before this change: 79.0%. The JavaScript frontend has no coverage measurement yet, so it is not in the figure.Verified locally
composer.lock; it runs only becausecomposer.jsongained a script, so it is inherited.composer check:strictonce: phpcs, psalm, phpstan and the full PHPUnit suite (2,802 tests) pass. phpmd fails onlib/findings this change does not touch (inherited).AI assistance: prepared with Claude Code (Opus 5.5) and reviewed before submission.