Converts description keywords to be env vars - #114
Merged
Conversation
aln730
approved these changes
Sep 4, 2026
Member
|
lgtm.(eli told me irl that he also ran this in dev and it worked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
what the PR changes
Changes the keywords in the description of calendar events, and also allows them to be env variables
Why
why these changes were made
Updated to better reflect what eboard wants, and now allows for hot switching in OKD
Test Plan
how did you verify these changes did what you expected
Changed them and it works
Env Vars
did you add, remove, or rename any environment variables
SLACK_MEETINGS_KEYWORD=""
SLACK_NONTECHNICAL_SEMINAR_KEYWORD=""
SLACK_TECHNICAL_SEMINAR_KEYWORD=""
Documentation
did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.
No
Checklist