Fix wireless_disable_interface remediations to work multiple interfaces

[alanmcanonical]

Description:

• Fix find to work with xargs -0
• Follow symlink in ansible

Rationale:

• The bash remediation mis-parses the interface list when more than one wireless interface is present, because it pipes newline-separated find output into xargs -0.
• The paths defined there are symlinks

[openshift-ci]

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_wireless_disable_interfaces' differs.
--- xccdf_org.ssgproject.content_rule_wireless_disable_interfaces
+++ xccdf_org.ssgproject.content_rule_wireless_disable_interfaces
@@ -11,7 +11,7 @@
 
 if command -v wicked >/dev/null 2>&1 && systemctl is-active wickedd >/dev/null 2>&1; then
   if [ -n "$(find /sys/class/net/*/ -type d -name wireless)" ]; then
-    interfaces=$(find /sys/class/net/*/wireless -type d -name wireless | xargs -0 dirname | xargs basename)
+    interfaces=$(find /sys/class/net/*/wireless -type d -name wireless -print0 | xargs -0 -n1 dirname | xargs -n1 basename)
     for iface in $interfaces; do
       wicked ifdown $iface
       sed -i 's/STARTMODE=.*/STARTMODE=off/' /etc/sysconfig/network/ifcfg-$iface

[macko1]

Hi @alanmcanonical, could you please update the PR title and description to follow the template, and explain the scenario being fixed and the test scenarios?

It will help speed up the review a lot. Thanks!

[alanmcanonical]

The target scenario is interface being present more than one.

[macko1]

Also please update the heading to something like.

Fix wireless_disable_interface remediations.

Thanks.

[macko1]

@alanmcanonical LGTM, thanks for the fix.

Did you test this? How?

[alanmcanonical]

@alanmcanonical LGTM, thanks for the fix.

Did you test this? How?

Tested by dummy files instead of interface.

[macko1]

@alanmcanonical LGTM, thanks for the fix.
Did you test this? How?

Tested by dummy files instead of interface.

For future updates, please provide the test scenarios before marking the PR as ready. This can also help for self-review (even if tested with the dummy files - that's how I found the bug).

Please make the commit messages descriptive (you can probably rebase/squash these with a short commit msg) as we do merge commits and these will appear in the history. See https://complianceascode.readthedocs.io/en/latest/manual/developer/04_style_guide.html#commit-messages

Otherwise LGTM
Thanks 👍.