T3271 - FIX Wrong message at sponsorship creation

[danpa32]

The bug was in the @api.depends decorator (line 507) — it only lists payment_mode_id but the compute body also reads child_id, birthday_invoice, and christmas_invoice. So when you add a child on a new form, the compute doesn't re-run, is_gift_authorized stays False from the previous run, and the view shows the warning even though no annual gift is set.

[gemini-code-assist]

Code Review

This pull request updates the @api.depends decorator for the _compute_is_gift_auth method in sponsorship_compassion/models/contracts.py to include additional dependencies: child_id, birthday_invoice, and christmas_invoice. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[greptile-apps]

Confidence Score: 5/5

Safe to merge.

The change is narrowly scoped to compute dependencies for an existing sponsorship field and does not alter the underlying business logic.

T-Rex Logs

What T-Rex did

• Observed that the initial base dependencies included only payment_mode_id.
• Set child_id and observed that no onchange recompute was triggered, after_is_gift_authorized remained False, and after_warning_condition remained True.
• Observed after setting child_id that the head dependencies expanded to include payment_mode_id, child_id, birthday_invoice, and christmas_invoice; recompute was triggered, after_is_gift_authorized became True, and after_warning_condition became False.
• Both commands exited with status 0 and captured the full command, working directory, commit, executed source, scenario inputs, operation, and resulting values.

_{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "The bug was in the @api.depends decorato..." | Re-trigger Greptile}