Skip to content

[T3244] FIX: open log-interaction wizard when interaction resume is empty#2104

Merged
Danielgergely merged 2 commits into
14.0from
T3244-log-interaction-empty-list
Jun 24, 2026
Merged

[T3244] FIX: open log-interaction wizard when interaction resume is empty#2104
Danielgergely merged 2 commits into
14.0from
T3244-log-interaction-empty-list

Conversation

@Danielgergely

Copy link
Copy Markdown
Member

Fall back to the list context when the resume has no rows, so data[0] is no longer read on an empty list.

…mpty

Fall back to the list context when the resume has no rows, so data[0]
is no longer read on an empty list.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the _onLogInteraction function in tree_button.js to safely handle cases where the state's data array is empty. However, the current implementation attempts to call state.getContext(), which will result in a TypeError since the state object does not have this method. The context should instead be accessed directly via state.context.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread interaction_resume/static/src/js/tree_button.js Outdated
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The change is narrowly scoped to the log interaction button context handling and appears safe to merge.

No issues were identified in the updated behavior, and the fallback avoids reading from an empty list while preserving the existing wizard action flow.

T-Rex T-Rex Logs

What T-Rex did

  • Verified that empty-list now calls do_action for partner.log.other.interaction.wizard with the payload from state.getContext() ({"default_partner_id":123,"active_model":"res.partner"}), and that non-empty still opens the wizard from the row context.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "[T3244] REF: use state.context instead o..." | Re-trigger Greptile

Comment thread interaction_resume/static/src/js/tree_button.js Outdated
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Danielgergely Danielgergely merged commit 8229693 into 14.0 Jun 24, 2026
1 check passed
@Danielgergely Danielgergely deleted the T3244-log-interaction-empty-list branch June 24, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant