Skip to content

[T3241] FIX: stamp exit communication on send completion (_job_sent)#2103

Merged
Danielgergely merged 5 commits into
14.0from
exit-com-not-sent-highlight-bug
Jun 23, 2026
Merged

[T3241] FIX: stamp exit communication on send completion (_job_sent)#2103
Danielgergely merged 5 commits into
14.0from
exit-com-not-sent-highlight-bug

Conversation

@Danielgergely

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the stamping of exit communications by extracting the configuration retrieval into a helper method and triggering the stamping specifically during job completion (_job_sent) and cancellation. A review comment suggests optimizing _stamp_exit_communications to only update and clean contracts that are actually pending (to_clean), preventing potential overwrites of the exit_communication_sent timestamp on re-sends and avoiding unnecessary database operations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread partner_communication_compassion/models/partner_communication.py Outdated
@greptile-apps

greptile-apps Bot commented Jun 22, 2026

Copy link
Copy Markdown

Confidence Score: 4/5

The change is narrowly scoped to exit communication finalization and appears safe to merge.

The updated behavior aligns stamping with successful send completion while preserving cancellation handling and existing recorded notification dates.

T-Rex T-Rex Logs

What T-Rex did

  • Observed the initial state where base send() stamped exit_communication_sent='NOW-1', flipped pending to False, and called cancel_contract_invoices before any _job_sent completion; the base _job_sent did not stamp.
  • Observed after the artifact capture that head send() left sent=False and pending=True, while _job_sent('email') stamped sent='NOW-1', flipped pending=False, and called cancel_contract_invoices once.
  • Observed after the artifact capture that cancel() remained stamped sent='NOW-2', flipped pending=False, and cancel_contract_invoices was called once for the exit communication.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (5): Last reviewed commit: "FIX: greptile comment No. 10052342..." | Re-trigger Greptile

Comment thread partner_communication_compassion/models/partner_communication.py Outdated
Comment thread partner_communication_compassion/models/partner_communication.py Outdated
Comment thread partner_communication_compassion/models/partner_communication.py Outdated
Comment thread partner_communication_compassion/models/partner_communication.py Outdated
@Danielgergely Danielgergely merged commit a52a7f7 into 14.0 Jun 23, 2026
2 checks passed
@Danielgergely Danielgergely deleted the exit-com-not-sent-highlight-bug branch June 23, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant