[T3241] FIX: stamp exit communication on send completion (_job_sent)#2103
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the stamping of exit communications by extracting the configuration retrieval into a helper method and triggering the stamping specifically during job completion (_job_sent) and cancellation. A review comment suggests optimizing _stamp_exit_communications to only update and clean contracts that are actually pending (to_clean), preventing potential overwrites of the exit_communication_sent timestamp on re-sends and avoiding unnecessary database operations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Confidence Score: 4/5The change is narrowly scoped to exit communication finalization and appears safe to merge. The updated behavior aligns stamping with successful send completion while preserving cancellation handling and existing recorded notification dates.
What T-Rex did
Reviews (5): Last reviewed commit: "FIX: greptile comment No. 10052342..." | Re-trigger Greptile |
No description provided.