Add InstaNovo and InstaNovo+ import support - #73
Conversation
On recent JDKs the Nimbus look and feel can throw a benign ClassCastException (ColorUIResource cannot be cast to Boolean in NimbusStyle.isOpaque) while building chart popup menus. The exception is still logged but no longer shown to the user, as it does not affect functionality.
ThermoRawFileParser writes mzML files with the canonical .mzML extension. Declaring the format ending as .mzML lets consumers find the converted file on case-sensitive file systems.
log4j-core was bumped to 2.25.4 while log4j-api stayed at 2.23.1, causing a NoSuchFieldError at runtime. Bump log4j-api to 2.25.4 to match.
|
Hello @hbarsnes, Any feedback on this PR and the related PRs? I'm happy to make any requested changes or answer questions if anything needs clarification. |
|
Hi @BioGeek, I'm afraid that all of the projects affected by your pull requests are no longer in active development and have not been so for quite some time. We sadly therefore do not have the time and resources to verify the changes, correct any potential conflicts or reply to new issues if there would be any. I also think that the number of users of these tools have been rapidly diminishing over the last couple of years (largely due to the lack of updates and improvements). Hence, there would probably not be a lot to gain by adding new features at this point. This situation is not expected to change, and at some point the gap compared to similar tools will simply be too big for it to make sense to put in the required effort. |
InstaNovo is a de novo peptide sequencing tool.
This PR adds support for normalized CSV output from InstaNovo v1.2.2 in three modes:
This PR forms the basis for a bunch of related PRs within the CompOmics ecosystem.
Changes
InstaNovoInstaNovo+InstaNovo with refinement.instanovo.csv.instanovoplus.csv.instanovo.refined.csvSupporting Fixes
Shared fixes needed for the InstaNovo de novo end-to-end flow (SearchGUI → PeptideShaker):
.mzML(the canonical extension the tool writes) so converted spectra are found on case-sensitive file systems.log4j-apito 2.25.4 to match the bumpedlog4j-core, fixing a runtimeNoSuchFieldError.ClassCastException(ColorUIResource cannot be cast to Boolean) thrown while building chart popup menus on recent JDKs.Implementation Notes
Tests
Ran:
mvn -Dtest=com.compomics.util.test.experiment.io.identifications.TestInstaNovoIdfileReader,com.compomics.util.test.parameters.identification.tool_specific.TestInstaNovoParameters test mvn -DskipTests -Dmaven.javadoc.skip=true installCovered by tests:
scan=tokens.Merge Order
Recommended order: