Report downloading and byte progress from the partner node download helper - #16248
Open
vqt123 wants to merge 1 commit into
Open
Report downloading and byte progress from the partner node download helper#16248vqt123 wants to merge 1 commit into
vqt123 wants to merge 1 commit into
Conversation
vqt123
marked this pull request as ready for review
September 11, 2026 02:57
vqt123
requested review from
Kosinkadink,
alexisrolland,
comfyanonymous,
guill,
kijai and
rattus128
as code owners
September 11, 2026 02:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partner node fetching its result sits at 0% until the file is complete, then jumps to 100%. The download helper every partner node goes through already counts bytes written and already has the response's Content-Length, and reports neither.
Sets the node's activity to "downloading" for the length of the transfer (the hook from #16202) and reports bytes written against the declared length through the existing ProgressBar, which throttles the sends. No declared length: the word only. A retry starts the count again.
Stacked on #16202; retarget to master once that merges.
Tests: tests-unit/comfy_api_nodes_test/download_progress_test.py (local aiohttp test server, with and without Content-Length).
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms