Add generic attention key-measure execution support - #16239
Draft
xmarre wants to merge 1 commit into
Draft
Conversation
This was referenced Sep 10, 2026
xmarre
force-pushed
the
mirror/mixed-grid-measure-core-20260910
branch
from
September 11, 2026 02:33
efd54b9 to
e395bb9
Compare
This was referenced Sep 11, 2026
xmarre
force-pushed
the
mirror/mixed-grid-measure-core-20260910
branch
from
September 11, 2026 04:03
e395bb9 to
8406da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the generic core contract and execution support required for heterogeneous MiniMax-H3 mixed-grid attention.
What this adds
attention_measure_v1normalization/validation with positive rational per-key measure and semantic digesting;The weighted route preserves all Q/K/V rows. Spatial carrier density is represented by adding
log(measure_k)to attention logits. It does not implement representative-K/V deletion or downsampling.Compatibility invariants
(block_index, rows, uuids).kmean/vscale) are not modified by the key measure; only weighted cache identity is measure-specific.attention_measure_v1request retain their prior numerical semantics.Validation
The current clean head
8406da920f9df19cbc14b76aef1bcd3dc4cf1119is one implementation commit on current upstreammaster1d48d9cf7bcecb6022a87b3cb13e0fb435bf9b8a.Focused cache-hardening run
34560181433completed 11 passed across the attention-measure contract suite and the new cache regression. The regression first proves a legitimate cache hit, then separately rejects a changed H3 layout, changed API-2 external geometry, and replacement of the registered capability owner.The exact clean head also passes fork Python-lint run
34560729867: both Ruff and Pylint completed successfully.Current companion structural validation was rerun from Spectrum run
34561055104, pinned to:8406da920f9df19cbc14b76aef1bcd3dc4cf1119;a6bf395133c8ce496217ca9194f3ab3f2b9181ef;d5f158a1c1750d79b37cb6ef22b0f14e6a8cbad6.The weighted Core-BSA / Flow / VDN / Spectrum targeted suites completed 43 passed, 1 skipped. The single skip is the separate Untwist-composition fixture, which was intentionally not installed in that targeted run; it is not part of the weighted Core/Flow/VDN contract being revalidated.
These are structural/CPU compatibility evidence only. They do not establish GPU numerical or decoded-media correctness.
Still required before production release:
18 logical / 14 actual / 4 forecastschedule;Authoritative architecture: https://github.com/xmarre/MiniMax-H3-Flow-Aligned-Regenerate/blob/3afc6c63063f410afec756c42811a8cf1ad2ed77/docs/MIXED_GRID_MEASURE_ARCHITECTURE.md
Companion design PR: xmarre/MiniMax-H3-Flow-Aligned-Regenerate#29