N°9643 - Dataflow: split protocol & type, add url and last change

[v-dumas]

Base information

Question	Answer
Related to a Combodo ticket?	N°9643
Type of change?	Enhancement

Objective (enhancement)

Implement feedback from partner

Proposed solution (bug and enhancement)

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailed enough so anyone can understand without digging in the code?

[greptile-apps]

Greptile Summary

The PR separates data-flow protocols from data-flow types and adds documentation URL and last-change metadata.

• Defines the new DataFlowProtocol typology and structural seed data.
• Updates DataFlow fields and presentation layouts.
• Adds labels and descriptions across the supported dictionaries.
• Corrects the previously reported French last_change_date dictionary keys.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
datamodels/2.x/itop-flow-map/datamodel.itop-flow-map.xml	Adds protocol, documentation URL, and last-change fields plus the new protocol typology and related UI presentation.
datamodels/2.x/itop-flow-map/module.itop-flow-map.php	Registers separate structural seed files for data-flow types and protocols.
datamodels/2.x/itop-flow-map/dictionaries/fr.dict.itop-flow-map.php	Adds French translations for the new fields and fixes the previously mismatched last-change dictionary keys.
datamodels/2.x/itop-flow-map/data/data.itop-dataflowprotocol.xml	Provides illustrative structural records for the new protocol typology.

_{Reviews (2): Last reviewed commit: "Fix missing comma in dictionaries" | Re-trigger Greptile}

[Copilot]

Pull request overview

Adds separate data-flow type and protocol typologies, plus documentation URL and last-change metadata.

Changes:

• Adds protocol, URL, and last-change fields.
• Splits default type and protocol data.
• Updates five translations.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
module.itop-flow-map.php	Registers typology data files.
datamodel.itop-flow-map.xml	Extends the data model and UI.
data.itop-dataflowtype.xml	Updates default flow types.
data.itop-dataflowprotocol.xml	Adds default protocols.
en.dict.itop-flow-map.php	Adds English labels.
fr.dict.itop-flow-map.php	Adds French labels.
nl.dict.itop-flow-map.php	Adds Dutch labels.
ru.dict.itop-flow-map.php	Adds Russian labels.
zh_cn.dict.itop-flow-map.php	Adds Chinese labels.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Hipska]

Link to documentation should be done by using Document tab, adding separate field for this removes unity across objects.

A URL specifying where te flow goes to would be interesting however.

[Hipska]

@v-dumas what do you think about my comment?

[v-dumas]

I did not capture what you wanted.
I am only applying the result of the discussion we had a month ago.
Documents tab is available, as it's a FunctionalCI, but it came out that a direct url was quicker to find.
If you want to use it for another purpose than documentation, fare, just rename it.

[Hipska]

I did not capture what you wanted.

well, you could have asked.

Also, with this logic, every FunctionalCI should have a documentation_url, I don’t see why DataFlow is special in that regard…