Repository navigation
fix: confirm dashboard process quit, accurate CLI help, security contact - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppState.requestProcessTermination(pid:)instead ofkillProcess. That opens the same dialog the AI Copilot already used ("Terminate this process?", "PID: n. SIGTERM will be sent first.", Cancel / Terminate Normally). Only Terminate Normally sends SIGTERM (force: false). The dialog moved fromAICopilotViewto the rootMainView, so it appears on every screen. That also fixes the Autonomous Guard "Terminate Process" button, which previously set the pending PID and showed no dialog until the user opened AI Copilot.aiKillConfirmationPID/confirmAIProcessTermination()were renamed topendingTerminationPID/confirmProcessTermination(), andcancelProcessTermination()was added. The dialog buttons now use theaistring table; before,Button("Cancel")looked up the main bundle and wasn't translated. No new strings were needed.--include-trashnow says: "Also list Trash items; with --execute --yes, permanently delete them (no confirmation beyond --yes)." This matches the code.SECURITY.mdnow listsinfo@codifya.cominstead ofsecurity@osmancagrigenc.dev. No other doc or source file had a contact address.Process-termination call sites
DashboardView→LiveTopProcessesCard.onKillMainViewalert (new)AppState.executeAIAction(.killProcess)fromAICopilotView(insight + chat action buttons)MainViewalert (unchanged behavior; dialog moved)AppState.executeAIAction(.killProcess)fromAutonomousGuardViewMainViewalert (previously no dialog was visible on that screen)MemoryViewalert →appState.killProcess(pid:force: true).alert"Terminate Process / Quit %@ (PID)? Unsaved data may be lost." → Force QuitforceTerminate()(unchanged)AppState.killProcess→MemoryOptimizerService.terminateProcessSafetyGuard.isProcessKillableenforced)forceSafeOperationExecutor.terminateProcessforceProcessExecutor/SandboxedCommandRunnerSIGTERM→SIGKILL escalation only touches child processes the app itself spawned (timeouts), not user processes.NSApplication.terminateinMacOptimizerAppquits the app itself.Test plan
swift buildcleanswift test: 91 tests, 0 failures, including newtestProcessTerminationWaitsForExplicitConfirmationandtestCLIHelpDoesNotPromiseExtraTrashConfirmation🤖 Generated with Claude Code