Skip to content

feat(l10n): localize service messages and model display names - #16

Merged
osmcgrgenc merged 1 commit into
mainfrom
l10n/services-core
Sep 28, 2026
Merged

osmcgrgenc merged 1 commit into
mainfrom
l10n/services-core

Conversation

@osmcgrgenc

Copy link
Copy Markdown
Contributor

Summary

Localizes user-visible hardcoded Turkish strings in JunkCleaner, AutonomousGuard, DuplicateFileFinder, AppUninstaller, AppUpdateChecker, AppScanner and SystemMonitor services plus the JunkItem / InstalledApp / LaunchAgentItem models, using the services table.

  • 106 new keys appended to en.lproj/services.strings and tr.lproj/services.strings (existing Unknown key reused; no stringsdict needed — counts are shown as x/y or abbreviated units).
  • Format specifiers are identical in both languages (%@, %d, %lld, %%).

Raw-value handling (unchanged)

  • DuplicateFileFinderService.ScanTargetDirectory raw values (İndirilenler, Belgeler, Resimler, Masaüstü) are the Identifiable.id and live in a Set in DuplicateFinderView; kept stable, added localizedTitle, view switched from target.rawValue to target.localizedTitle.
  • AppUpdateInfo.UpdateSource raw values (incl. Doğrudan Kontrol) kept; added localizedTitle (product names pass through, .directCheck localized); AppUpdatesView badge switched to it.
  • LaunchItemType and AppArchitecture raw values kept; they are never displayed (only compared by case). AppArchitecture.shortName (Diğer) localized.
  • JunkCategoryType.title/description are computed display properties (raw values are English ids) — localized in place.
  • Battery condition == "Normal" is compared in BatteryAnalyticsCard; "Normal" left as-is (identical in both languages), other conditions localized.

Tests

  • swift build OK; swift test full suite: 83 tests, 0 failures (incl. localization completeness).
  • testAutonomousGuardCycle title assertions were Turkish-only; extended with English alternatives (Memory, Thermal) since titles now follow the system language.

Test plan

  • swift build
  • swift test (83/83)
  • Manual check in Turkish and English on device

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@osmcgrgenc
osmcgrgenc merged commit 60774b9 into main Sep 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant